Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make private_endpoint_label unique per test run of TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseFullExample #12523

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Make private_endpoint_label unique per test run of TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseFullExample #12523

merged 1 commit into from
Dec 11, 2024

Conversation

SarahFrench
Copy link
Contributor

@SarahFrench SarahFrench commented Dec 9, 2024 •
edited
Loading

Final, final PR to close hashicorp/terraform-provider-google#19983

TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseFullExample currently fails with:

------- Stdout: -------
=== RUN   TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseFullExample
=== PAUSE TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseFullExample
=== CONT  TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseFullExample
    resource_oracle_database_autonomous_database_generated_test.go:98: Step 1/2 error: Error running apply: exit status 1
        Error: Error waiting to create AutonomousDatabase: Error waiting for Creating AutonomousDatabase: Error code 3, message: generic::invalid_argument: InvalidParameter: Provisioning Autonomous Database failed Cause: Operation failed because a private endpoint with the specified hostname prefix testhost already exists in the tenancy. Specify a different hostname prefix and try again.
          with google_oracle_database_autonomous_database.myADB,
          on terraform_plugin_test.tf line 2, in resource "google_oracle_database_autonomous_database" "myADB":
           2: resource "google_oracle_database_autonomous_database" "myADB"{
--- FAIL: TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseFullExample (612.81s)
FAIL

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 9, 2024
@SarahFrench SarahFrench mentioned this pull request Dec 9, 2024
Closed
@modular-magician modular-magician added service/oracledatabase and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Dec 9, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 3 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 3 insertions(+), 2 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 14
Passed tests: 13
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • oracledatabase

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

@SarahFrench SarahFrench marked this pull request as ready for review December 9, 2024 11:03
@github-actions github-actions bot requested a review from BBBmau December 9, 2024 11:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@SarahFrench SarahFrench merged commit 1faadb6 into GoogleCloudPlatform:main Dec 11, 2024
17 checks passed
This was referenced Dec 11, 2024
Merged
Merged
Merged
Merged
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
@SarahFrench @amanMahendroo
Make private_endpoint_label unique per test run of `TestAccOracleDa…
3adeeb2 
…tabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseFullExample` (GoogleCloudPlatform#12523)
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Feb 17, 2025
@SarahFrench @niharika-98
Make private_endpoint_label unique per test run of `TestAccOracleDa…
3e74fd5 
…tabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseFullExample` (GoogleCloudPlatform#12523)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BBBmau BBBmau BBBmau approved these changes

Assignees
No one assigned
Labels
service/oracledatabase
Projects
None yet
Milestone
No milestone
3 participants
@SarahFrench @modular-magician @BBBmau